Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cypress): payout - fix test cases for adyenplatform bank #6887

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore(cypress): payout - fix test cases for adyenplatform bank #6887

wants to merge 4 commits into from
+4 −3

Conversation

kashif-m
Copy link
Contributor

@kashif-m kashif-m commented Dec 19, 2024 •
edited by pixincreate
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR fixes the cypress payout test cases for AdyenPlatform connector.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Helps in enabling the Adyenplatform connector for payout cypress test cases as a part of Github CI checks.

How did you test it?

Locally.

Screenshot 2024-12-19 at 12 33 27 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@kashif-m kashif-m requested a review from a team as a code owner December 19, 2024 07:03
@kashif-m kashif-m linked an issue Dec 19, 2024 that may be closed by this pull request
[BUG] fix cypress test cases for adyenplatform #6886
Open
2 tasks
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Dec 19, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  .github/workflows/cypress-tests-runner.yml Unsupported file format
  cypress-tests/cypress/e2e/PayoutUtils/AdyenPlatform.js  0% smaller

pixincreate
pixincreate previously approved these changes Dec 19, 2024
View reviewed changes
@kashif-m kashif-m requested a review from a team as a code owner December 19, 2024 08:51
pixincreate
pixincreate reviewed Dec 19, 2024
View reviewed changes
Copy link
Member

@pixincreate pixincreate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than that, lgtm

.github/workflows/cypress-tests-runner.yml Outdated Show resolved Hide resolved
@pixincreate pixincreate added A-CI-CD Area: Continuous Integration/Deployment C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Dec 19, 2024
@pixincreate pixincreate added this to the December 2024 Release milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumanmaji4 sumanmaji4 sumanmaji4 approved these changes

@pixincreate pixincreate pixincreate approved these changes

Assignees

@kashif-m kashif-m

Labels
A-CI-CD Area: Continuous Integration/Deployment C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed
Projects
None yet
Milestone
December 2024 Release
Development

Successfully merging this pull request may close these issues.

[BUG] fix cypress test cases for adyenplatform
3 participants
@kashif-m @pixincreate @sumanmaji4